Fix Node::getPath() on Windows when files are on two logical disks #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbergmann
added a commit
that referenced
this pull request
Apr 16, 2015
Fix Node::getPath() on Windows when files are on two logical disks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Windows Jenkins build server, I have PHP on the
C:\drive and the code I'm testing phpunit with onE:\.The unit tests are running fine, but the Clover and Crap4j reports are empty. The skeleton XML is there, but no files are listed.
I've found that something has changed since the fixes for #93 and #106 went in that addressed this very problem. After
reducePaths()runs, the common root node's name (ofC:\andE:\) is nowfalseinstead ofnullas the previous address checked.Checking for
falsein addition tonullfixes this issue.