Skip to content

Conversation

@Slamdunk
Copy link
Contributor

@Slamdunk Slamdunk commented Feb 7, 2022

See #868 (comment)

The method does nothing: unset($file); has no effect on anything, it's just an unused local array key

@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #890 (d4c391b) into 9.2 (7ec58cf) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                9.2     #890      +/-   ##
============================================
+ Coverage     83.03%   83.19%   +0.15%     
+ Complexity     1117     1112       -5     
============================================
  Files            62       62              
  Lines          3655     3648       -7     
============================================
  Hits           3035     3035              
+ Misses          620      613       -7     
Impacted Files Coverage Δ
src/CodeCoverage.php 44.95% <ø> (+0.18%) ⬆️
src/ProcessedCodeCoverageData.php 100.00% <ø> (+6.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ec58cf...d4c391b. Read the comment docs.

@dvdoug
Copy link
Contributor

dvdoug commented Feb 7, 2022

Apparently I had a major brain fart when writing that, and I should also look at why the test didn't reproduce the scenario accurately enough. However, the issue it was added for (#864) is real so I'd prefer fixing this up to do what it should be doing (unset($this->lineCoverage[$file], $this->functionCoverage[$file])) rather than removing it.

@sebastianbergmann sebastianbergmann merged commit b098639 into sebastianbergmann:9.2 Feb 8, 2022
@Slamdunk Slamdunk deleted the remove_useless_code branch February 8, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants