Skip to content

fix: Support files without exported locals #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2019
Merged

fix: Support files without exported locals #16

merged 2 commits into from
May 29, 2019

Conversation

@kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented May 29, 2019

This fixes #15 by removing a check on the existence of localExports and adding a passing test.

@kraenhansen kraenhansen mentioned this pull request May 29, 2019
Closed
@markdalgleish markdalgleish changed the title fix: No exported locals found (#15) fix: Support files without exported locals May 29, 2019
markdalgleish
markdalgleish approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thanks for the PR 👏

@markdalgleish markdalgleish merged commit b8c738b into seek-oss:master May 29, 2019
@jackple jackple mentioned this pull request May 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@markdalgleish markdalgleish markdalgleish approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: No exported locals found

2 participants

@kraenhansen @markdalgleish