Mode 'verify' and tests do not run on Windows #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made 'verify' mode stable for Windows by always converting line separators to LF before comparing content (Windows / git might create / convert to CRLF).
Fixed tests for Windows.
mattcompiles
approved these changes
Sep 20, 2019
Collaborator
mattcompiles
left a comment
mattcompiles
left a comment
There was a problem hiding this comment.
Thanks for this. 🍻
Sorry the PR sat for so long. We don't have Windows machines so I couldn't validate the fix until now.
Contributor
Author
|
Thanks for merging! 🍻 |
silbinarywolf
added a commit
to silbinarywolf/css-modules-typescript-loader
that referenced
this pull request
Oct 18, 2019
…sing index signature syntax, ie. a['my-selector'] (seek-oss#20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19 by converting CRLF's to LF's before comparing generated code and content of existing files in 'verify' mode.
Fixes tests by replacing backslashes in file pathes by slashes before comparing with snapshot.