This repository was archived by the owner on Sep 3, 2022. It is now read-only.
pin trim version #219
Merged
pin trim version #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliofarah
approved these changes
Nov 25, 2020
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
Apr 16, 2021
* pin trim version * update History.md
hbrls
pushed a commit
to nice-fungal/analytics.js-core
that referenced
this pull request
May 31, 2021
* pin trim version * update History.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR patches the ReDoS vulnerability with the
trimpackage. This package was used in the following dependencies:component-querystringfacade( the version used by AJS classic )I have to go to the yarn resolution route, as the
component-querystringhasn't published the updated package.Test plan
Testing completed successfully using local unit tests;
Testing completed successfully using local e2e build of the final bundle;
Release plan
Checklist