Release Java SDK 7.0.0 Blog Post #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
Release_Java_Sdk_7.0.0
branch
from
bbf1981 to
f30d4a4
Compare
fjtirado
force-pushed
the
Release_Java_Sdk_7.0.0
branch
6 times, most recently
from
f5f68b9 to
8f39f94
Compare
JBBianchi
reviewed
Jan 31, 2025
fjtirado
force-pushed
the
Release_Java_Sdk_7.0.0
branch
from
8f39f94 to
8c29738
Compare
fjtirado
force-pushed
the
Release_Java_Sdk_7.0.0
branch
from
8c29738 to
3635a69
Compare
JBBianchi
approved these changes
Jan 31, 2025
cdavernas
requested changes
Jan 31, 2025
Member
cdavernas
left a comment
cdavernas
left a comment
There was a problem hiding this comment.
Please fix the title and description: Adding release blog is not a proper PR title:
- it is not ubiquitous: what is released?
- it is incorrect: you are not adding a blog, but a blog post
- the tense is incorrect and goes against GH recommendations. It should use imperative tense
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado
force-pushed
the
Release_Java_Sdk_7.0.0
branch
from
3635a69 to
74c267b
Compare
Contributor
Author
To be honest I do not even check it :).... changed |
ricardozanini
approved these changes
Jan 31, 2025
Member
ricardozanini
left a comment
ricardozanini
left a comment
There was a problem hiding this comment.
LGTM! Just a few nitpick suggestions
Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Update src/content/blog/releases/release-sdk-java-7.0.0.md Co-authored-by: Ricardo Zanini <[email protected]> Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
fjtirado
force-pushed
the
Release_Java_Sdk_7.0.0
branch
from
c85c4ff to
f04ae78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new blog post for the Java SDK v7.0.0 release