lints + flow

[alexeuler]

This change is 

[justin808]

@robwise @alexfedoseev How about we put this into the shakacode linter?

[robwise]

@justin808 I commented on the styleguide repo, what's the reasoning?

[alex35mil]

@justin808 It should be:

react/jsx-filename-extension:
  - 1
  - extensions: [".js"]

# or

react/jsx-filename-extension:
  - 1
  - extensions: [".jsx"]

In general I'm fine w/ either, but as we already have a big codebase, that's using .jsx, I'd stay were we are as there's no reason to spend time on this change.

[justin808]

@robwise are you suggesting that it's better to mark files with jsx with a .jsx extension?

[justin808]

@robwise @alexfedoseev Should these go into the shakacode linter?

[alex35mil]

Isn't it React Native specific?

[robwise]

These aren't React-Native specific, these are used when typing React with flow. If you use eslint-plugin-flowtype, defining these as globals isn't necessary and these can be removed. I would also recommend using the recommend configuation.

[alex35mil]

This is crazy train, I can't find anything about ReactElement here. AFAIR I had issues w/ it and bunch of examples were using React$Element—it is in the defs, but it wasn't work either. Then I found this post, where stated that ReactElement is removed from public API and React.Element should be used instead. The funny thing is that it worked and still works, but: there is no Element property on React object lol.

[robwise]

@robwise are you suggesting that it's better to mark files with jsx with a .jsx extension?

@justin808 Yes that's what we've always been doing. If it has JSX in it, it's a jsx file. If it doesn't, it's a JS file.

[justin808]

@robwise @alexfedoseev as far as I can tell, the FB examples for react and react-native don't use the jsx extension.

[robwise]

@justin808 We shouldn't deviate from the Airbnb styleguide unless we have a good reason. We would have to change an unbelievably monstrous number of files on F&G if we implement this. It's a good rule IMO anyway.