Skip to content

add logo for golang (#3337) #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Conversation

grampelberg
Copy link
Contributor

Why:

I'd like to have the golang logo show up for code blocks when the filename is included.

Closes: #3337

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added the SVG logo from golang, updated the icon exports and added to rehype's replacements.

Check off the following:

  • I have reviewed my changes in staging, available via the View
    deployment
    link in this PR's timeline (this link will be available after
    opening the PR).

    • For content changes, you will also see an automatically generated comment
      with links directly to pages you've modified. The comment won't appear if
      your PR only edits files in the data directory.
  • For content changes, I have completed the
    self-review checklist.

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 0034f62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra Major
nextra-theme-docs Major
nextra-theme-blog Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:18pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 7:18pm

Copy link

vercel bot commented Oct 2, 2024

@grampelberg is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks bad on dark mode

image

I'll fix it in your branch

@dimaMachina dimaMachina merged commit 5fbce2f into shuding:main Oct 2, 2024
4 of 9 checks passed
@grampelberg grampelberg deleted the thomas--go-icon branch October 2, 2024 19:29
@grampelberg
Copy link
Contributor Author

Thank you! Now I've got a new list of stuff to check for PRs:)

@dimaMachina
Copy link
Collaborator

Amazing! feel free to create new issues or contribute 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing icon for golang
2 participants