Skip to content

Timer with predefined endTime doesn't resume from stoppedTime #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ideapad
Copy link
Contributor

@ideapad ideapad commented Jan 18, 2018

Timer with predefined endTime doesn't resume from the time when it was stopped.
Check the example - example
Solution: update endTime according to the time when timer resumes.

Intuitive digramm showing current implementation :
screen shot 2018-01-18 at 11 29 14 pm

After fix :
screen shot 2018-01-18 at 10 55 09 pm

…on: update endTime when resume() is called.
@skorokithakis skorokithakis merged commit d58fbf8 into siddii:master Dec 8, 2018
@skorokithakis
Copy link
Collaborator

Very clear explanation, thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants