Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of all the PWM drivers to return a parameters stucture pointer of void* type on initialisation (if successful).
The same pointer is passed to the _writeDutyCycle() methods instead of passing all the pins each time.
At the moment this is in status "in development", but since there is no easy way to do this "driver by driver", I wanted to switch them all over early in this release cycle to give us plenty of time to test the changes, which affect every architecture.
So far I have tried it out on:
This change is ready for testing, but there will be further changes as we work with it:
But these changes should not further affect the outward facing API of the drivers.
I think we should merge it into dev now, and then we can properly start on low side current sensing... as we implement this we will try out all the architectures...