- 
                Notifications
    You must be signed in to change notification settings 
- Fork 106
  Permalink
    
      
      
  
  
    
  
    
  
      
    
  
      
  
    
    
  
  
    
      Choose a base ref
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
    
    {{ refName }}
    default
  
           
        
        
          
            
              
              
           
        
       
     
  
  
  
    
  
    
  
    
  
      
    
  
      
  
    
    
  
  
    
      Choose a head ref
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
    
    {{ refName }}
    default
  
           
        
        
          
            
              
              
           
        
       
     
  
  
          
    
        
              
  
  
        
  
  
  
        
  
  
  
        
        
  
    
  
      
        
    
              
      
  
    
  
      
  
   
  Comparing changes
          Choose two branches to see what’s changed or to start a new pull request.
            If you need to, you can also    or
          learn more about diff comparisons.
  
Open a pull request
          Create a new pull request by comparing changes across two branches. If you need to, you can also   .
        Learn more about diff comparisons here.
  
base repository: socketio/socket.io-parser
        Failed to load repositories. Confirm that selected base ref is valid, then try again.
      
      
        
      Loading
      
  base: 4.2.1
Could not load branches
            
              
      Nothing to show
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
    
    {{ refName }}
    default
  
            
                
      Loading
              
            
      
      
        ...
      
head repository: socketio/socket.io-parser
        Failed to load repositories. Confirm that selected head ref is valid, then try again.
      
      
        
      Loading
      
  compare: 4.2.2
Could not load branches
            
              
      Nothing to show
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
    
    {{ refName }}
    default
  
            
                
      Loading
              
            - 7 commits
- 14 files changed
- 2 contributors
Commits on Nov 9, 2022
- 
  
  Configuration menu - View commit details
- 
    
    
    Copy full SHA for f0af883 
- Browse repository at this point
 Copy the full SHA f0af883View commit details 
Commits on Nov 15, 2022
- 
  Configuration menu - View commit details
- 
    
    
    Copy full SHA for a9758da 
- Browse repository at this point
 Copy the full SHA a9758daView commit details 
- 
  ci: migrate from zuul to webdriver.io zuul is now archived [1] and does not support the new W3C WebDriver protocol, since it relies on the wd package [2] under the hood, which uses the (now deprecated) JSON Wire Protocol. We will now use the webdriver.io test framework, which allows to run our tests in local and on Sauce Labs (cross-browser and mobile tests). This allows us to run our tests on latest versions of Android and iOS, since Sauce Labs only supports the W3C WebDriver protocol for these platforms ([3]). [1]: https://github.com/defunctzombie/zuul [2]: https://github.com/admc/wd [3]: https://docs.saucelabs.com/dev/w3c-webdriver-capabilities/ Configuration menu - View commit details
- 
    
    
    Copy full SHA for 194a9b7 
- Browse repository at this point
 Copy the full SHA 194a9b7View commit details 
- 
  Configuration menu - View commit details
- 
    
    
    Copy full SHA for 9143aa4 
- Browse repository at this point
 Copy the full SHA 9143aa4View commit details 
Commits on Jan 19, 2023
- 
  fix: do not modify the input packet upon encoding Note: this issue has existed since Socket.IO v1.0 (see [1]), because the `deconstructPacket()` method also mutates its input argument. This also explains why some adapters (like [2]) need to use `process.nextTick()` when extending the `broadcast()` method, because `Adapter.broadcast()` calls `Encoder.encode()` ([3]). Related: - socketio/socket.io#4374 - socketio/socket.io-mongo-adapter#10 [1]: 299849b [2]: https://github.com/socketio/socket.io-postgres-adapter/blob/0.3.0/lib/index.ts#L587-L590 [3]: https://github.com/socketio/socket.io-adapter/blob/2.4.0/lib/index.ts#L148 Configuration menu - View commit details
- 
    
    
    Copy full SHA for ae8dd88 
- Browse repository at this point
 Copy the full SHA ae8dd88View commit details 
- 
  fix: calling destroy() should clear all internal state If a client was in the process of receiving some binary attachments when the connection was abruptly closed, then the manager would call `decoder.destroy()` ([1]) but was then stuck in a "parse error" loop upon reconnection (since it expected a binary attachment and not a CONNECT packet). [1]: https://github.com/socketio/socket.io-client/blob/a1c528b089773d7810a03befaeb982f7e01c3e11/lib/manager.ts#L520 Configuration menu - View commit details
- 
    
    
    Copy full SHA for 22c42e3 
- Browse repository at this point
 Copy the full SHA 22c42e3View commit details 
- 
  
  Configuration menu - View commit details
- 
    
    
    Copy full SHA for 28dd668 
- Browse repository at this point
 Copy the full SHA 28dd668View commit details 
        
      Loading
      
      This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
            You can try running this command locally to see the comparison on your machine: 
            git diff 4.2.1...4.2.2