-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Liquid Cooling leakage detection in SONiC #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/azp run |
No pipelines are associated with this pull request. |
@judyjoseph , could you please help to review? |
/azp run |
No pipelines are associated with this pull request. |
/azp run |
No pipelines are associated with this pull request. |
@judyjoseph Can you help review this HLD? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comments
/azp run |
No pipelines are associated with this pull request. |
thanks, add more details on your comment |
Signed-off-by: Yuanzhe, Liu <[email protected]>
/azp run |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lguohan could you review too, anything which you would like w.r.to cooling leakage detection. Any other related working going on in cooling. thanks |
This is my HLD for the liquid cooling leakage detection, it provides a basic liquid cooling object to reflect the hardware as well as a mechanism to monitor the leakage sensors of it.
PR List:
sonic-net/sonic-platform-common#603
sonic-net/sonic-platform-daemons#690
sonic-net/sonic-utilities#4068
sonic-net/sonic-buildimage#24124
sonic-net/sonic-buildimage#24125