Fix trixie compilation #1040
Merged
Fix trixie compilation #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Jul 14, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
previously approved these changes
Jul 15, 2025
Make some changes to fix compilation for Debian Trixie. This includes: * Don't mark m_buffer as const, since the memory that it's pointing to is anyways modified by `BinarySerializer`. * Add support for compiling with libhiredis 1.1.0. * Add a missing include for `<stdexcept>`. * Use `SWIG_AppendOutput` instead of `SWIG_Python_AppendOutput`, as the latter now takes another parameter to indicate if the function's return type is void, and the recommendation appears to be to just use `SWIG_AppendOutput`. * Add a workaround for GCC complaining about attributes being ignored in a template argument when passing in `pclose` as a function pointer into `std::unique_ptr`.[1] [1] This is based on https://stackoverflow.com/a/76867913 Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
force-pushed
the
fix-trixie-compilation
branch
from
b898e4b to
e66b0be
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
With the base image upgrade to Trixie, Bookworm-based containers will need to use Boost 1.83. This is because of an incompatibility between rsyslog_plugin that uses Boost 1.83 on Trixie and the eventd container that uses Boost 1.74 on Bookworm; specifically there is an incompatiblity with serialization of objects between the two versions of Boost. Because of this, allow applications to compile with Boost 1.83 headers. Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Pterosaur
approved these changes
Aug 6, 2025
|
Cherry-pick PR to msft-202506: Azure/sonic-swss-common.msft#52 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
|
@prabhataravind What's the reason for needing this in the msft-202506 branch? None of the fixes/changes here should be needed in any current branch, I think. |
@saiarcot895 We usually cherry-pick only smartswitch related and build fixes from master to 202506 branch for swss-common, sairedis and dash-api, dash-ha repos. I took this change to avoid potential conflicts/build issues down the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some changes to fix compilation for Debian Trixie. This includes:
BinarySerializer.<stdexcept>.SWIG_AppendOutputinstead ofSWIG_Python_AppendOutput, as the latter now takes another parameter to indicate if the function's return type is void, and the recommendation appears to be to just useSWIG_AppendOutput.pcloseas a function pointer intostd::unique_ptr.[1][1] This is based on https://stackoverflow.com/a/76867913