Add keyStoreAlgorithm and trustStoreAlgorithm configuration option to configure RabbitConnectionFactory #24076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Nov 9, 2020
There was a problem hiding this comment.
Thanks very much for the pull request, @topikachu. I've left a few minor comments. If you have the time, please take a look at them and let us know what you think.
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
Outdated
Show resolved
Hide resolved
| private String trustStorePassword; | ||
|
|
||
| /** | ||
| * Trust stroe algorithm. |
There was a problem hiding this comment.
Small typo here. Should be "store" rather than "stroe".
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Trust stroe algorithm. | ||
| */ | ||
| private String trustStoreAlgorithm; |
There was a problem hiding this comment.
The initial value of this field should be SunX509. This aligns it with Spring AMQP's default for the property.
.../src/test/java/org/springframework/boot/autoconfigure/amqp/RabbitAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/boot/autoconfigure/amqp/RabbitAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
Outdated
Show resolved
Hide resolved
| private String keyStorePassword; | ||
|
|
||
| /** | ||
| * Key stroe algorithm. |
There was a problem hiding this comment.
Small typo here. Should be "store" rather than "stroe".
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
Outdated
Show resolved
Hide resolved
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitProperties.java
Outdated
Show resolved
Hide resolved
…re and trust store algorithm Add keyStoreAlgorithm and trustStoreAlgorithm to RabbitProperties and adopt at Rabbit AutoConfig.
wilkinsona
approved these changes
Nov 9, 2020
wilkinsona
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Dec 15, 2020
snicoll
added a commit
that referenced
this pull request
Dec 15, 2020
|
@topikachu thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keyStoreAlgorithm and trustStoreAlgorithm to RabbitProperties and adopt at Rabbit AutoConfig.