Skip to content

Introduce placeholder resolution support in @ConcurrencyLimit #35470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Introduce placeholder resolution support in @ConcurrencyLimit #35470

wants to merge 1 commit into from

Conversation

HyunSangHan
Copy link
Contributor

This change introduces property placeholder resolution support in @ConcurrencyLimit.
I tried to closely follow the approach used in @Retryable, and based this work on c9078bf. 👀

  • Added ConcurrencyLimit#valueString() attribute with placeholder support
  • Implemented EmbeddedValueResolverAware in ConcurrencyLimitBeanPostProcessor
  • Added integration tests for property resolution

Closes gh-35461

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 12, 2025
@HyunSangHan HyunSangHan mentioned this pull request Sep 13, 2025
Closed
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Sep 14, 2025
@sbrannen sbrannen self-assigned this Sep 14, 2025
@sbrannen sbrannen added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 14, 2025
@sbrannen sbrannen added this to the 7.0.0-RC1 milestone Sep 14, 2025
@sbrannen sbrannen marked this pull request as draft September 14, 2025 10:36
@sbrannen sbrannen changed the title Introduce valueString attribute for placeholder resolution in @ConcurrencyLimit Introduce placeholder resolution support in @ConcurrencyLimit Sep 14, 2025
@sbrannen sbrannen marked this pull request as ready for review September 22, 2025 14:08
@sbrannen sbrannen closed this in 91f112a Sep 22, 2025
sbrannen added a commit that referenced this pull request Sep 22, 2025
@sbrannen
Introduce @⁠ConcurrencyLimit(limit) and revise contribution
73ad1eb 
This commit introduces a new `limit` attribute in @⁠ConcurrencyLimit as
an alias for the existing `value` attribute. This commit also renames
the `valueString` attribute to `limitString`.

See gh-35461
See gh-35470
@sbrannen
Copy link
Member

Hi @HyunSangHan,

Congratulations on submitting your first PR for the Spring Framework! 👍

This has been merged into main in 91f112a and revised in 73ad1eb.

Thanks

@sbrannen sbrannen mentioned this pull request Sep 22, 2025
Closed
sbrannen added a commit that referenced this pull request Sep 29, 2025
@sbrannen
Update @⁠ConcurrencyLimit documentation
2bd6422 
This commit updates the reference manual in order to reflect recent
changes made to @⁠ConcurrencyLimit.

See gh-35461
See gh-35470
See gh-35523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sbrannen sbrannen

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

Projects

None yet

Milestone

7.0.0-RC1

Development

Successfully merging this pull request may close these issues.

Introduce placeholder resolution support in @ConcurrencyLimit

3 participants

@HyunSangHan @sbrannen @spring-projects-issues