Skip to content

feat: support json schema #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2025
Merged

feat: support json schema #909

merged 2 commits into from
Oct 16, 2025

Conversation

phoenisx
Copy link
Contributor

@phoenisx phoenisx commented Oct 16, 2025 •
edited
Loading

Resolves: #889

Screen.Recording.2025-10-16.at.8.08.23.PM.mov

@phoenisx phoenisx mentioned this pull request Oct 16, 2025
Closed
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Oct 16, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

nene
nene requested changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@nene nene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

There are some mistakes though in it. Mainly in descriptions.

nene
nene requested changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@nene nene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

I should point out though that I find it quite annoying to receive fixes through a force-push. It means I can't see a diff of the changes, so I essentially need to re-review everything again.

@nene
Copy link
Collaborator

nene commented Oct 16, 2025

Also, I wonder is there any reason for creating a separate directory for this one JSON file? If no, then I would just place it into the root dir of the repository.

@nene
Copy link
Collaborator

nene commented Oct 16, 2025 •
edited
Loading

Also, we should add a few words about the existence of this schema file to README. Or maybe just include the $schema entry inside the config file example in there.

@nene
Copy link
Collaborator

nene commented Oct 16, 2025

Thanks.

@nene nene merged commit b9d2db9 into sql-formatter-org:master Oct 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nene nene nene requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: $schema for .sql-formatter.json

2 participants

@phoenisx @nene