Skip to content

Conversation

@lucydodo
Copy link
Member

@lucydodo lucydodo commented Aug 15, 2020

I recently made a pull request(#2347) to move the recent file list to a sub-menu and
received a suggestion to change the value of MaxRecentFiles during the review process.

Accordingly, I modified the code to allow the user to change the value of MaxRecentFiles.
In addition, I re-added the separator that was lost according to the existing patch.

Thank you.

Test Environment

  • macOS Catalina (10.15.6, 19G2021)

@justinclift justinclift added the enhancement Feature requests. label Aug 15, 2020
@lucydodo lucydodo changed the title User can change MaxRecentFiles Allow the user can change to the value of MaxRecentFiles Aug 17, 2020
@lucydodo lucydodo changed the title Allow the user can change to the value of MaxRecentFiles Allow the user can change MaxRecentFiles Aug 17, 2020
@lucydodo
Copy link
Member Author

May I ask for a review of my code?

@MKleusberg
Copy link
Member

@lucydodo Sure. I'll have a look later today 😄

@MKleusberg
Copy link
Member

Thanks, @lucydodo! Looks good 👍

@MKleusberg MKleusberg merged commit 54ee47b into sqlitebrowser:master Aug 17, 2020
@lucydodo
Copy link
Member Author

Thanks to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants