Fix #2583: quote identifiers, not expressions #2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94023a5 switched to storing OrderBy terms by column name and/or expression instead of by column index, and includes a test to ensure that identifiers are quoted and raw expressions are not; unfortunately it seems to have gotten the logic backwards.
oldlaptop
changed the title
|
Thanks for the patch, @oldlaptop! |
|
@MKleusberg You might want to look over this too, just for awareness. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
94023a5 switched to storing OrderBy terms by column name or expression instead of by column index, and includes a test to ensure that identifiers are quoted and raw expressions are not; unfortunately it seems to have gotten the logic backwards. See #2583.