Skip to content

Conversation

@mgrojo
Copy link
Member

@mgrojo mgrojo commented Sep 12, 2022

No description provided.

@mgrojo
Copy link
Member Author

mgrojo commented Sep 12, 2022

@justinclift, this is my blind attempt to fix the Windows build after looking at PR #3068 and the SQLCipher repository. Would you mind running the Windows nightly scripts and see what happens?

@justinclift
Copy link
Member

@mgrojo Thanks. I can try it in a few hours, after I get some sleep. Have been setting up a new Windows build server, so this is good timing. 😄

@justinclift
Copy link
Member

Oh wow, that worked first go. Awesome! Really well done @mgrojo! 😄

@justinclift justinclift merged commit 2db65f4 into master Sep 13, 2022
@justinclift justinclift deleted the fix_win_pr_3068 branch September 13, 2022 17:26
@justinclift
Copy link
Member

Although the macOS build VM no longer works (it's being replaced over next few days), we can just leave the Windows builds still running as they should work for now.

I'll update some other things on the VM, then generate new Win32/64 builds.

Thanks heaps for figuring this out @mgrojo! 😄

@chrisjlocke
Copy link
Member

Zip it up and email me the Windows disk image.... ;) Should only be 50 GB or so... ;)

@mgrojo
Copy link
Member Author

mgrojo commented Sep 13, 2022

Oh, nice, I should buy lottery this week 😄

@justinclift
Copy link
Member

Definitely. 😁

@mgrojo mgrojo restored the fix_win_pr_3068 branch October 14, 2023 21:27
@mgrojo mgrojo deleted the fix_win_pr_3068 branch October 14, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants