Feature/table action buttons #1053
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A default edit and delete button can be included by specifying an "edit_url" or "delete_url" * Custom Column based action buttons can be added in the table header using json object array in the custom_actions column. * Custom action buttons can be defined on the row level by specifying _sqlpage_actions.
… centered, and _col_{name} is included in new rows.
cargo clippy
Checking sqlpage v0.38.0
error: redundant else block
--> src\webserver\http.rs:493:6
|
493 | } else {
| ______^
494 | | if let Some(domain) = &config.https_domain {
495 | | let mut listen_on_https = listen_on;
496 | | listen_on_https.set_port(443);
... |
511 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_else
note: the lint level is defined here
--> src\lib.rs:1:9
|
1 | #![deny(clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[deny(clippy::redundant_else)]` implied by `#[deny(clippy::pedantic)]`
help: remove the `else` block and move the contents out
|
493 ~ }
494 + if let Some(domain) = &config.https_domain {
495 + let mut listen_on_https = listen_on;
496 + listen_on_https.set_port(443);
497 + log::debug!("Will start HTTPS server on {listen_on_https}");
498 + let config = make_auto_rustls_config(domain, config);
499 + server = server
500 + .bind_rustls_0_23(listen_on_https, config)
501 + .map_err(|e| bind_error(e, listen_on_https))?;
502 + } else if listen_on.port() == 443 {
503 + bail!("Please specify a value for https_domain in the configuration file. This is required when using HTTPS (port 443)");
504 + }
505 + if listen_on.port() != 443 {
506 + log::debug!("Will start HTTP server on {listen_on}");
507 + server = server
508 + .bind(listen_on)
509 + .map_err(|e| bind_error(e, listen_on))?;
510 + }
|
error: could not compile `sqlpage` (lib) due to 1 previous error
…enix79-spec/SQLPage into feature/table-action-buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive support for action buttons in the
tablecomponent, allowing users to easily add edit, delete, and custom action buttons at both the table and row level. The documentation and template have been updated to explain and render these new features, making it much easier to include buttons in table data.Example of table with action buttons.
Table action button support
edit_urlanddelete_urlproperties to thetablecomponent, enabling automatic rendering of Edit and Delete buttons for each row. These URLs can include a{id}placeholder that is replaced by the row's_sqlpage_id. [2]custom_actionsproperty at the table level and_sqlpage_actionsat the row level, allowing for flexible, user-defined action buttons with custom icons, tooltips, and links. [2]Limitations
Example placeholder
{ "name": "action" }Example custom_action
{ "name": "history", "tooltip": "View Standard History", "link": "./history.sql?standard_id={id}", "icon": "history" }Documentation and examples
01_documentation.sqlwith detailed explanations and a full example of usingedit_url,delete_url,custom_actions, and_sqlpage_actionsin tables. [1]Template changes
table.handlebarsto render Edit, Delete, and custom action buttons in both the table header and body, including dynamic tooltips and icons. [2]id="{{component_index}}-search"to the search input for improved accessibility and easier DOM manipulation. [2]