Skip to content

Revert "refactor: Replace lazy_static with std::sync::LazyLock (#827)" #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Aug 8, 2024

Description

This reverts commit f15a9a3.

We still need Rust 1.79.0 compatibility until 1.80 percolates into Nixpkgs.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

nightkr added 2 commits August 8, 2024 16:25
This reverts commit f15a9a3.

We still need Rust 1.79.0 compatibility until 1.80 percolates into Nixpkgs.
@nightkr nightkr requested a review from a team August 8, 2024 14:27
@nightkr nightkr marked this pull request as ready for review August 8, 2024 14:27
@sbernauer
Copy link
Member

I would prefer merging this, so that we can merge dependent PRs (such as stackabletech/hdfs-operator#571 and stackabletech/druid-operator#584).
Yes, we are loosing some doc comment changes as well, but I would simply cherry-pick the reverted commit once we are ready for 1.80 and the changes should be back :)

sbernauer
sbernauer previously approved these changes Aug 9, 2024
@sbernauer
Copy link
Member

Once this is merged we can IMHO release 0.73.0 :)

@nightkr
Copy link
Member Author

nightkr commented Aug 9, 2024

We can always revert the revert :)

@nightkr nightkr added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 2bac6b3 Aug 9, 2024
20 checks passed
@nightkr nightkr deleted the revert/lazylock branch August 9, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants