Skip to content

EthernetClient.setTimeout shadows Stream.setTimeout #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JAndrassy opened this issue Sep 28, 2023 · 0 comments · Fixed by #74
Closed

EthernetClient.setTimeout shadows Stream.setTimeout #72

JAndrassy opened this issue Sep 28, 2023 · 0 comments · Fixed by #74
Labels
enhancement New feature or request
Milestone
1.4.0

Comments

@JAndrassy
Copy link
Contributor

EthernetClient has setTimeout instead of setConnectionTimeout. setTimeout shadows Stream.setTimeout
@fpistm fpistm added the enhancement New feature or request label Sep 28, 2023
@fpistm fpistm added this to the 1.3.1 milestone Sep 28, 2023
fpistm added a commit to fpistm/STM32Ethernet that referenced this issue Sep 28, 2023
@fpistm
fix(client): setTimeout shadows Stream.setTimeout
9474719 
Rename it setConnectionTimeout to match Arduino Ethernet API.

Fixes stm32duino#72

Signed-off-by: Frederic Pillon <[email protected]>
@fpistm fpistm mentioned this issue Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
STM32duino libraries
Status: Done
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

fix(client): setTimeout shadows Stream.setTimeout fpistm/STM32Ethernet
2 participants
@JAndrassy @fpistm