Update JOSDK to v5.1.2

[OwenCorrigan76]

This PR migrates the Java Operator SDK from v4.4.2 to v5.1.2. The updated vesrion will allow Access Operator to watch Kafka clusters in a remote Kubernetes cluster, as requested in issue #44.

This PR directly addresses the follwoing issue: #89

[im-konge]

Thanks for the PR, few comments.

[katheris]

Thanks for the PR @OwenCorrigan76. I think we need some additional changes for the switch to SSA and I don't think the Kafka Access Secret event source is being used correctly. Also from reviewing the migration docs I think we need to change the way we use the SDK generation to use the maven plugin.

[OwenCorrigan76]

@katheris @im-konge I've reverted the SSA stuff in CreateOrUpdateSecret and tests are passing and I've tested changes in a cluster and working as expected.
Do we need to revert these changes:

[im-konge]

@OwenCorrigan76 about the unused declared dependency -> you removed the ObservedGenerationAwareStatus from the KafkaAccessStatus so I think it's not needed anymore in the api module. Did you try to remove it?

[OwenCorrigan76]

@OwenCorrigan76 about the unused declared dependency -> you removed the ObservedGenerationAwareStatus from the KafkaAccessStatus so I think it's not needed anymore in the api module. Did you try to remove it?

That's exactly the reason. Thanks @im-konge

[im-konge]

Thanks for the changes, few more comments.

[im-konge]

Suggested change

	@SuppressWarnings({"ClassFanOutComplexity"})
	@SuppressWarnings("ClassFanOutComplexity")

I think that you can revert this change

[OwenCorrigan76]

Sorry, I had "ClassDataAbstractionCoupling" at one stage and didn't remove the }'s.

[im-konge]

Suggested change

	* Prepares the event sources required for triggering the reconciliation. This tells the JOSDK framework which resources the operator needs to watch.
	* Prepares the event sources required for triggering the reconciliation.
	* It configures the JOSDK framework with resources the operator needs to watch.

Or something like that?

[im-konge]

Maybe we should add the SSA implementation issue link into the comment?

[OwenCorrigan76]

Would it look like this:

    void beforeEach() {
        operator = new Operator(overrider -> overrider.withKubernetesClient(client)
                /**
                 * Disables the use of Server-Side Apply for patching the primary resource.
                 * Motivation: Mock Kubernetes client doesn't fully support SSA features.
                 * See: <a href="https://github.com/fabric8io/kubernetes-client/issues/5337">fabric8io/kubernetes-client Issue #5337</a>
                 **/
                .withUseSSAToPatchPrimaryResource(false));
        operator.register(new KafkaAccessReconciler(operator.getKubernetesClient()));
        operator.start();
    }

Or what's the best format for the comment? Thanks

[OwenCorrigan76]

Regarding the following: return ErrorStatusUpdateControl.updateStatus(kafkaAccess);
This is deprecated in v5. The only options are : patchStatus , patchResource and patchResourceAndStatus

[im-konge]

Sorry for my ignorance, for what is this used for?

[OwenCorrigan76]

Added to test something and forgot to remove. Will remove

[katheris]

Thanks @OwenCorrigan76 I think we're pretty close now, but a couple more changes needed.

[katheris]

Suggested change

	public Long getObservedGeneration() {
	public long getObservedGeneration() {

[katheris]

Suggested change

	public void setObservedGeneration(Long observedGeneration) {
	public void setObservedGeneration(long observedGeneration) {

[katheris]

Presumably we need a matching change to this in the Operator class right? So it applies when running the actual operator as well as in the tests.