-
-
Notifications
You must be signed in to change notification settings - Fork 175
Enhancements to docker images #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For some reason, this disrupts the ansible process - Err: the connection plugin 'local' was not found
dragarcia
commented
Nov 26, 2021
Comment on lines
25
to
26
username: ${{ secrets.DOCKER_USERNAME }} | ||
password: ${{ secrets.DOCKER_PASSWORD }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
values not set yet
dragarcia
commented
Nov 26, 2021
with: | ||
context: . | ||
push: true | ||
tags: supabase/postgres:latest,supabase/postgres:v${{ version }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one too
- move more cleanup to the Dockerfile - run everything under one command in the Dockerfile
- Need to configure runners first - Will uncomment in another PR once done
dragarcia
added a commit
that referenced
this pull request
Dec 2, 2021
* chore: bump postgres and pgbouncer - #67 #68 * chore: #65 sha-scram-256 encryption * chore: Bump to Postgres 14.0 * chore: bump up existing extensions * Use PG 14 version of postgresql.conf * move up running of SQL files - to a part where the DB is still up and running * new extensions: - rum - pg_hashids * Cleanup build dependencies immediately after installation * Remove hardcoded values for Postgres major * Update variables * Update wal-g installation process * add build dependencies for supautils * changes to pgbouncer config - use scram-sha-256 encryption - list out additional build dependencies - assign postgres as stats user * Revert "Cleanup build dependencies immediately after installation" This reverts commit 25c93de. * Minimise packages cleaned up - some extensions were dependent to them * link pg binaries only at the end * remove postgres as pgbouncer stats_users * bump to Postgres 14.1 * rename filename for pgsodium * update regex for session_preload_libraries * Update README * update download URLs for postgrest * Bump versions * feat: build AMIs using Github Actions (#101) * feat: build AMIs using Github Actions * eliminate two-step build Co-authored-by: dragarcia <[email protected]> * Transfer ownership of pgbouncer process to pgbouncer user * increased timeout for get_url * further hardening of pgbouncer - no access to public schema - cannot connect to port 5432 by pgbouncer user other than localhost * bump common.vars.json * Enhancements to docker images (#108) * GA for dockerhub * Shift removal of unused packages at the bottom - For some reason, this disrupts the ansible process - Err: the connection plugin 'local' was not found * No longer use init.sh for docker * Use Dockerfile when building docker images * cleanup /tmp via the Dockerfile * more changes to docker build - move more cleanup to the Dockerfile - run everything under one command in the Dockerfile * Commenting these out for now - Need to configure runners first - Will uncomment in another PR once done * ignore caretion of symbolic link for plv8 in docker arm build * Temporarily remove CI files for Dockerhub Co-authored-by: Div Arora <[email protected]>
hf
pushed a commit
that referenced
this pull request
Jan 23, 2023
* chore: bump postgres and pgbouncer - #67 #68 * chore: #65 sha-scram-256 encryption * chore: Bump to Postgres 14.0 * chore: bump up existing extensions * Use PG 14 version of postgresql.conf * move up running of SQL files - to a part where the DB is still up and running * new extensions: - rum - pg_hashids * Cleanup build dependencies immediately after installation * Remove hardcoded values for Postgres major * Update variables * Update wal-g installation process * add build dependencies for supautils * changes to pgbouncer config - use scram-sha-256 encryption - list out additional build dependencies - assign postgres as stats user * Revert "Cleanup build dependencies immediately after installation" This reverts commit 25c93de. * Minimise packages cleaned up - some extensions were dependent to them * link pg binaries only at the end * remove postgres as pgbouncer stats_users * bump to Postgres 14.1 * rename filename for pgsodium * update regex for session_preload_libraries * Update README * update download URLs for postgrest * Bump versions * feat: build AMIs using Github Actions (#101) * feat: build AMIs using Github Actions * eliminate two-step build Co-authored-by: dragarcia <[email protected]> * Transfer ownership of pgbouncer process to pgbouncer user * increased timeout for get_url * further hardening of pgbouncer - no access to public schema - cannot connect to port 5432 by pgbouncer user other than localhost * bump common.vars.json * Enhancements to docker images (#108) * GA for dockerhub * Shift removal of unused packages at the bottom - For some reason, this disrupts the ansible process - Err: the connection plugin 'local' was not found * No longer use init.sh for docker * Use Dockerfile when building docker images * cleanup /tmp via the Dockerfile * more changes to docker build - move more cleanup to the Dockerfile - run everything under one command in the Dockerfile * Commenting these out for now - Need to configure runners first - Will uncomment in another PR once done * ignore caretion of symbolic link for plv8 in docker arm build * Temporarily remove CI files for Dockerhub Co-authored-by: Div Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
Set up GA for pushing out to Docker HubUtilising Dockerfile implementation above/etc/postgersql/
instead of copying them over to/var/lib/postgresql/data/