Skip to content

Enhancements to docker images #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 29, 2021
Merged

Conversation

dragarcia
Copy link
Contributor

@dragarcia dragarcia commented Nov 25, 2021

Objectives

  • Usage of Dockerfile
  • Set up GA for pushing out to Docker Hub
    • Utilising Dockerfile implementation above
    • Will leave this out for another PR once additional runners have been settled
  • Provide option for ARM64 docker image
  • General cleanup
    • Use config files in /etc/postgersql/ instead of copying them over to /var/lib/postgresql/data/
    • Remove init script that is no longer needed
    • Shift majority of cleaning up of the image to the Dockerfile instead of Ansible

@dragarcia dragarcia self-assigned this Nov 25, 2021
- For some reason, this disrupts the ansible process
- Err: the connection plugin 'local' was not found
Comment on lines 25 to 26
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

values not set yet

with:
context: .
push: true
tags: supabase/postgres:latest,supabase/postgres:v${{ version }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one too

- move more cleanup to the Dockerfile
- run everything under one command in the Dockerfile
- Need to configure runners first
- Will uncomment in another PR once done
@dragarcia dragarcia marked this pull request as ready for review November 29, 2021 05:23
@dragarcia dragarcia merged commit fcb9727 into feature/14.0.0 Nov 29, 2021
@dragarcia dragarcia deleted the chore/docker_enhancements branch November 29, 2021 06:12
dragarcia added a commit that referenced this pull request Dec 2, 2021
* chore: bump postgres and pgbouncer
- #67 #68

* chore: #65 sha-scram-256 encryption

* chore: Bump to Postgres 14.0

* chore: bump up existing extensions

* Use PG 14 version of postgresql.conf

* move up running of SQL files
- to a part where the DB is still up and running

* new extensions:
- rum
- pg_hashids

* Cleanup build dependencies immediately after installation

* Remove hardcoded values for Postgres major

* Update variables

* Update wal-g installation process

* add build dependencies for supautils

* changes to pgbouncer config
- use scram-sha-256 encryption
- list out additional build dependencies
- assign postgres as stats user

* Revert "Cleanup build dependencies immediately after installation"

This reverts commit 25c93de.

* Minimise packages cleaned up
- some extensions were dependent to them

* link pg binaries only at the end

* remove postgres as pgbouncer stats_users

* bump to Postgres 14.1

* rename filename for pgsodium

* update regex for session_preload_libraries

* Update README

* update download URLs for postgrest

* Bump versions

* feat: build AMIs using Github Actions (#101)

* feat: build AMIs using Github Actions

* eliminate two-step build

Co-authored-by: dragarcia <[email protected]>

* Transfer ownership of pgbouncer process to pgbouncer user

* increased timeout for get_url

* further hardening of pgbouncer
- no access to public schema
- cannot connect to port 5432 by pgbouncer user other than localhost

* bump common.vars.json

* Enhancements to docker images (#108)

* GA for dockerhub

* Shift removal of unused packages at the bottom
- For some reason, this disrupts the ansible process
- Err: the connection plugin 'local' was not found

* No longer use init.sh for docker

* Use Dockerfile when building docker images

* cleanup /tmp via the Dockerfile

* more changes to docker build
- move more cleanup to the Dockerfile
- run everything under one command in the Dockerfile

* Commenting these out for now
- Need to configure runners first
- Will uncomment in another PR once done

* ignore caretion of symbolic link for plv8 in docker arm build

* Temporarily remove CI files for Dockerhub

Co-authored-by: Div Arora <[email protected]>
hf pushed a commit that referenced this pull request Jan 23, 2023
* chore: bump postgres and pgbouncer
- #67 #68

* chore: #65 sha-scram-256 encryption

* chore: Bump to Postgres 14.0

* chore: bump up existing extensions

* Use PG 14 version of postgresql.conf

* move up running of SQL files
- to a part where the DB is still up and running

* new extensions:
- rum
- pg_hashids

* Cleanup build dependencies immediately after installation

* Remove hardcoded values for Postgres major

* Update variables

* Update wal-g installation process

* add build dependencies for supautils

* changes to pgbouncer config
- use scram-sha-256 encryption
- list out additional build dependencies
- assign postgres as stats user

* Revert "Cleanup build dependencies immediately after installation"

This reverts commit 25c93de.

* Minimise packages cleaned up
- some extensions were dependent to them

* link pg binaries only at the end

* remove postgres as pgbouncer stats_users

* bump to Postgres 14.1

* rename filename for pgsodium

* update regex for session_preload_libraries

* Update README

* update download URLs for postgrest

* Bump versions

* feat: build AMIs using Github Actions (#101)

* feat: build AMIs using Github Actions

* eliminate two-step build

Co-authored-by: dragarcia <[email protected]>

* Transfer ownership of pgbouncer process to pgbouncer user

* increased timeout for get_url

* further hardening of pgbouncer
- no access to public schema
- cannot connect to port 5432 by pgbouncer user other than localhost

* bump common.vars.json

* Enhancements to docker images (#108)

* GA for dockerhub

* Shift removal of unused packages at the bottom
- For some reason, this disrupts the ansible process
- Err: the connection plugin 'local' was not found

* No longer use init.sh for docker

* Use Dockerfile when building docker images

* cleanup /tmp via the Dockerfile

* more changes to docker build
- move more cleanup to the Dockerfile
- run everything under one command in the Dockerfile

* Commenting these out for now
- Need to configure runners first
- Will uncomment in another PR once done

* ignore caretion of symbolic link for plv8 in docker arm build

* Temporarily remove CI files for Dockerhub

Co-authored-by: Div Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant