Skip to content

[fix] make webcontainer integration more robust #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 18, 2022
Merged

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 18, 2022

  • add the wait time with the "reset iframe" hack for each time we (re)set the adapter
  • listen to server-ready event during reset, because for some reason it's fired then, too. This avoid a race condition where Vite could be requested too early, resulting in a timeout

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 3:29PM (UTC)

@dummdidumm dummdidumm marked this pull request as ready for review November 18, 2022 15:28
@dummdidumm dummdidumm merged commit c6439ae into main Nov 18, 2022
@dummdidumm dummdidumm deleted the robustness branch November 18, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant