Skip to content

[fix] webcontainer tweaks #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 30, 2022
Merged

[fix] webcontainer tweaks #114

merged 13 commits into from
Nov 30, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Nov 30, 2022 •
edited
Loading

  • remove steps logic, turns out starting up is very robust if it goes well
  • do a full page reload if something fails during initial boot
  • make webcontainer a real singleton internally
  • use the built-in rm method now (works now)
  • don't reload iframe if not needed (better DX when solving/resetting)

@dummdidumm
[fix] webcontainer tweaks
6809c6b 
- remove steps logic, turns out starting up is very robust if it goes well
- do a full page reload if something fails during initial boot
- make webcontainer a real singleton internally
@vercel
Copy link

vercel bot commented Nov 30, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 9:05PM (UTC)

@dummdidumm dummdidumm merged commit db2602b into main Nov 30, 2022
@dummdidumm dummdidumm deleted the webcontainer-tweaks branch November 30, 2022 21:08
@Rich-Harris Rich-Harris mentioned this pull request Feb 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dummdidumm