[fix] marked dependency for Part 1 / Bindings / Textarea inputs #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanbtrujillo is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
ivanbtrujillo
force-pushed
the
fix/text-area-excercise
branch
from
1a2d95b to
bff6e59
Compare
dummdidumm
approved these changes
Jan 23, 2023
content/tutorial/01-svelte/06-bindings/05-textarea-inputs/README.md
Outdated
Show resolved
Hide resolved
content/tutorial/01-svelte/06-bindings/05-textarea-inputs/README.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error about Marked not loading. What I've done is add the Marked dependency at the excercise level in the same way Elizabot was added for Part 1 / Lifecycle / beforeUpdate and afterUpdate excercise.
node_modules folder is pushed to the repo (same way than Elizabot).
Probably this is not the best way to do it, but it solves the issue for now. I think it worths to work on a script that runs npm install on any package.json under /content. This way we can remove the node_modules folder (by adding it to a .gitignore).
Before the fix:
After the fix:
