Skip to content

fix: typed characters to be entered correctly #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 2, 2023

Conversation

tomoam
Copy link
Contributor

@tomoam tomoam commented Feb 1, 2023

refs: #190 (comment), #190 (comment)

typed export let data;, but entered export let dat;. The a is missing.
So, I will create tests to not introduce regressions, and fix this issue.

lack.mov

@vercel
Copy link

vercel bot commented Feb 1, 2023

@tomoam is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@tomoam tomoam marked this pull request as ready for review February 2, 2023 07:02
@tomoam
Copy link
Contributor Author

tomoam commented Feb 2, 2023

@dummdidumm I could fix this. I would appreciate it if you could review it.

@vercel
Copy link

vercel bot commented Feb 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 2, 2023 at 9:20AM (UTC)

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!
I tested this manually with

  • typing something that breaks and unbreaks the output
  • navigating around in the iframe
  • clicking outside of the editor

and didn't find any bugs. The tests will surely help guard against regressions, too.

@dummdidumm dummdidumm merged commit 3324905 into sveltejs:main Feb 2, 2023
@tomoam
Copy link
Contributor Author

tomoam commented Feb 2, 2023

@dummdidumm Thank you very much!

@tomoam tomoam deleted the add-test branch February 21, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants