Skip to content

switch to codemirror #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 14, 2023
Merged

switch to codemirror #252

merged 9 commits into from
Mar 14, 2023

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 13, 2023

still various things to do

  • styling
  • focus management
  • see if there's any obvious functionality we're missing

once it works, it should be easier to add things like annotations, mobile support, etc

@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 1:19AM (UTC)

@Rich-Harris
Copy link
Member Author

The preview is noticeably faster to load (which is unsurprising if you look at the network tab). Monaco is a beast.

@Rich-Harris
Copy link
Member Author

(also, the console doesn't become unusable with bullshit errors/warnings)

Rich Harris added 2 commits March 13, 2023 20:36
@Rich-Harris Rich-Harris marked this pull request as ready for review March 14, 2023 01:21
@Rich-Harris Rich-Harris merged commit c562fbb into main Mar 14, 2023
@Rich-Harris Rich-Harris deleted the gh-47 branch March 14, 2023 01:22
@Rich-Harris Rich-Harris mentioned this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant