Skip to content

mobile layout #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2023
Merged

mobile layout #254

merged 2 commits into from
Mar 14, 2023

Conversation

Rich-Harris
Copy link
Member

#12. The 'input' screen needs some work

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 0:54AM (UTC)

@Rich-Harris
Copy link
Member Author

this isn't 'finished', but it works well enough that i'm going to merge it as-is then think about a redesigned version. i think it makes sense to have two screens rather than three — tutorial and editor/preview — with the file tree hidden behind a menu.

this will need some changes to the <SplitPane> component to avoid a flash of incorrect layout

@Rich-Harris Rich-Harris marked this pull request as ready for review March 14, 2023 13:08
@Rich-Harris Rich-Harris merged commit c1e1e58 into main Mar 14, 2023
@Rich-Harris Rich-Harris deleted the gh-12 branch March 14, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant