Skip to content

update vite, remove some unused code #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2023
Merged

update vite, remove some unused code #271

merged 3 commits into from
Mar 17, 2023

Conversation

Rich-Harris
Copy link
Member

we no longer need to force Vite to restart the server when .env is created, as this was fixed in 4.2

@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 9:13PM (UTC)

@Rich-Harris
Copy link
Member Author

huh. this seems to flake out when switching from e.g. /tutorial/welcome-to-svelte to /tutorial/env-dynamic-private

@Rich-Harris
Copy link
Member Author

oh, weird, it's still using 4.1.3 even though the package.json was updated 🤔

image

@Rich-Harris
Copy link
Member Author

ok clearing the build cache did the trick. i guess something about having the node_modules in a non-top-level directory and using npm for some stuff and pnpm for other stuff was enough to confuse it

@Rich-Harris Rich-Harris merged commit 49c9e66 into main Mar 17, 2023
@Rich-Harris Rich-Harris deleted the tidy-up branch March 17, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant