Skip to content

Add /// file annotations #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 21, 2023
Merged

Add /// file annotations #285

merged 7 commits into from
Mar 21, 2023

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 21, 2023

This makes the exercises a bit easier to understand and navigate. TODO:

  • when clicking an annotation for a file that doesn't yet exist, trigger the add action
  • add inline annotations for all files, not just those that exist at the start of the exercise. give them the same behaviour as the code block annotations
  • make missing annotations an error, to prevent regressions
  • create a /// no-file annotation so that we can explicitly opt out
  • on mobile, clicking an annotation should switch over to the editor view and cause a history.pushState. we probably need a ?file=blah query param (maybe this replaces ?view=editor rather than augmenting?)

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 21, 2023 at 9:38PM (UTC)

@Rich-Harris Rich-Harris marked this pull request as draft March 21, 2023 16:50
@Rich-Harris Rich-Harris marked this pull request as ready for review March 21, 2023 21:44
@Rich-Harris Rich-Harris merged commit d30e5a0 into main Mar 21, 2023
@Rich-Harris Rich-Harris deleted the gh-277 branch March 21, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant