Skip to content

chore: improve detection of iOS devices #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

chore: improve detection of iOS devices #391

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b414f11
chore: improve detection of iOS devices
tomoam May 16, 2023
76f98a6
fix a message
tomoam May 16, 2023
8c22e3a
add a comment
tomoam May 17, 2023
a9c3685
simplify the button text
tomoam May 17, 2023
67a7ee4
Merge branch 'main' into improve-to-detect-devices
tomoam May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix a message
  • Loading branch information
@tomoam
tomoam committed May 16, 2023
commit 76f98a6db45a8dff1d88377cc84879ecdde5fcc1
2 changes: 1 addition & 1 deletion src/lib/client/adapters/webcontainer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export async function create(base, error, progress, logs, warnings, force) {
if (!is_webcontainer_supported()) {
throw new Error('WebContainers are not supported by Safari 16.3 or earlier');
} else if (is_ios_device() && !force) {
throw new Error('maybe cause out of memory');
throw new Error('On iOS devices, your browser may run out of memory');
}

progress.set({ value: 0, text: 'loading files' });
Expand Down