Skip to content

fix: unavailable --prime css variable #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

mateusabelli
Copy link
Contributor

@mateusabelli mateusabelli commented Aug 10, 2023

This patch fixes the unavailable --prime css variable that were being used on two files. After doing some code searches for that color, I didn't find it anywhere on svelte.learn.dev or in site-kit repo, by it's name I'm confident that --sk-theme-1 should be it's natural replacement, but I'm available for future changes if requested.

fixes #454

src/routes/tutorial/[slug]/Sidebar.svelte

.modal-contents button {
  background-color: var(--sk-theme-1);
}
Before After
01-before 01-after

src/routes/tutorial/[slug]/Menu.svelte

li[aria-current='step']:not(.expanded) > button {
  color: var(--sk-theme-1);
}
Before After
02-before 02-after

Please let me know what do you think.

@vercel
Copy link

vercel bot commented Aug 10, 2023

@mateusabelli is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
learn-svelte-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 8:56am

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 9549b6a into sveltejs:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<button> is missing styles
2 participants