Skip to content

Conversation

cachemeifyoucan
Copy link

@cachemeifyoucan cachemeifyoucan commented Oct 9, 2025

Cleanup for code upstreaming. Noticeable changes:
* Hide some forward declared typesA.
* Rename all the database files and use a unified version across index
and dabasefile. This allows reset the version while not introduce
downstream incompatibility.
* Change unit-test to properly set a smaller file size and just not
building OnDiskCAS test

@cachemeifyoucan
Copy link
Author

@swift-ci please test llvm

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-code-cleanup branch from 7950626 to 8ff887a Compare October 9, 2025 21:39
@cachemeifyoucan
Copy link
Author

@swift-ci please test llvm

@cachemeifyoucan
Copy link
Author

This is a clean up for upstream review. NFC.

@cachemeifyoucan cachemeifyoucan changed the title OnDisk update/cleanup [CAS] OnDisk update/cleanup. NFCI. Oct 10, 2025
Copy link

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message/PR description should probably mention that we are changing from a per-file format version to a single version across the files (currently actions has a different version from the others).

Mostly LGTM. A few nits and suggestions.

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-code-cleanup branch 2 times, most recently from 2810a96 to d5c7e20 Compare October 13, 2025 22:58
@cachemeifyoucan
Copy link
Author

@swift-ci please test llvm

@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-code-cleanup branch from d5c7e20 to 4a756e3 Compare October 14, 2025 16:25
Cleanup for code upstreaming. Noticeable changes:
* Hide some forward declared typesA.
* Rename all the database files and use a unified version across index
  and dabasefile. This allows reset the version while not introduce
  downstream incompatibility.
* Change unit-test to properly set a smaller file size and just not
  building OnDiskCAS test.
@cachemeifyoucan cachemeifyoucan force-pushed the eng/PR-cas-code-cleanup branch from 4a756e3 to 87e64d0 Compare October 14, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants