Adopt Mutex (take 2)
#1363
Merged
Adopt Mutex (take 2)
#1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adopts `Mutex` on all platforms except Darwin (where we still need to back-deploy further than `Mutex` is available.) Resolves #538. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added
enhancement
grynspan
requested review from
briancroom,
jerryjrchen,
stmontgomery and
suzannaratcliff
as code owners
stmontgomery
approved these changes
Oct 12, 2025
|
Should be identical. |
|
Note to self: BSD commit? |
|
I can't see the CI results in #1353 (https://ci.swift.org/job/oss-swift-pr-test-ubuntu-22_04/9662/). Was the reason this was backed out because of a compilation failure due to swiftlang/swift#84771? |
jerryjrchen
approved these changes
Oct 13, 2025
|
That PR fixes the issue we ran into which our own CI jobs won't catch. See that issue for more info. |
|
The bug fixed in swiftlang/swift#84771 may still be present in the 6.2.x toolchain, but we don't expect to build this repo's main branch in release mode there, so I'm going to merge the change now. If we find this causes problems with the 6.2 toolchain, we can always revert again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts
Mutexon all platforms except Darwin (where we still need to back-deploy further thanMutexis available.)Blocked by swiftlang/swift#84771.
Reapplies #1351.
Resolves #538.
Resolves rdar://131832797.
Checklist: