Integer concrete comparisons #81895
Open
Integer concrete comparisons #81895
+826
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed concrete SIMDMask(lowHalf:highHalf:) init, as there is no corresponding generic operation; it was added in error.
There's no reason for these to ever be calls, so they should be transparent instead of just aEIC. Also adds concrete versions of comparisons with scalars, and filecheck tests to make sure these generate 1-2 instruction sequences in release on arm64 (x86_64 is a little trickier to test due to frame pointers, but if we get the right codgen on arm64, in practice we do well on x86_64 for these too). Also makes filecheck patterns for repeating initializers a bit more robust.
|
@swift-ci test |
This instruction was added in SSE4.1, which is in the baseline that macOS targets now, but not in the baseline for older macOS targets, nor for Linux or Windows. Eventually, we'll want to be able to slice these tests more finely by ISA extension targeted, but the arm64 coverage gets us what we need here.
|
@swift-ci test |
unsigned vector compares on x86 are pretty fragile (because it doesn't have them pre-AVX-whatever) and it turns out we generate different things for simulator and macOS and linux, so rather than trying to fit all of those into filecheck patterns, we just rely on the arm64 checks instead (the code itself is all generic, so this is not so unreasonable).
|
@swift-ci test |
|
Let's see if the Linux WASM failure is reproducible. |
|
@swift-ci test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.