[cxx-interop] Only swiftify template instantiations behind type aliases #81973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn,
beccadax and
ian-twilightcoder
as code owners
Xazax-hun
force-pushed
the
gaborh/disable-non-aliased-instantiations
branch
from
cdb813d to
b1b29ce
Compare
hnrklssn
approved these changes
Jun 4, 2025
hnrklssn
requested changes
Jun 4, 2025
Xazax-hun
force-pushed
the
gaborh/disable-non-aliased-instantiations
branch
2 times, most recently
from
53f1207 to
4a08305
Compare
Good point, updated the PR. |
hnrklssn
reviewed
Jun 5, 2025
While I could not trigger a scenario where the generated macro triggers a compilation error, the generated code is definitely not valid Swift. rdar://151422108
Xazax-hun
force-pushed
the
gaborh/disable-non-aliased-instantiations
branch
from
4a08305 to
868c85d
Compare
|
@swift-ci please smoke test |
hnrklssn
approved these changes
Jun 6, 2025
Xazax-hun
added a commit
that referenced
this pull request
Jun 9, 2025
…aliases Explanation: C++ template instantiations that are not behind type aliases don't have corresponding Swift names that are both syntactically and semantically valid types. This PR prevents generating swiftified overloads for those types. Issue: rdar://151422108 Risk: Low, we swiftify functions less often. Testing: Regression test added. Original PR: #81973 Reviewer: @hnrklssn
Xazax-hun
added a commit
that referenced
this pull request
Jun 11, 2025
…aliases Explanation: C++ template instantiations that are not behind type aliases don't have corresponding Swift names that are both syntactically and semantically valid types. This PR prevents generating swiftified overloads for those types. Issue: rdar://151422108 Risk: Low, we swiftify functions less often. Testing: Regression test added. Original PR: #81973 Reviewer: @hnrklssn
Xazax-hun
added a commit
that referenced
this pull request
Jun 12, 2025
…aliases Explanation: C++ template instantiations that are not behind type aliases don't have corresponding Swift names that are both syntactically and semantically valid types. This PR prevents generating swiftified overloads for those types. Issue: rdar://151422108 Risk: Low, we swiftify functions less often. Testing: Regression test added. Original PR: #81973 Reviewer: @hnrklssn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I could not trigger a scenario where the generated macro triggers a compilation error, the generated code is definitely not valid Swift.
rdar://151422108