Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

remove dev master dependencies #484

Merged
merged 1 commit into from
May 12, 2014
Merged

remove dev master dependencies #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions cookbook/creating_a_cms/getting-started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,26 +31,19 @@ all of the required packages now.
...
"symfony-cmf/routing-auto-bundle": "1.0.*@alpha",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this even make sense to include this Bundle in a tutorial until its stable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @dantleech

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't simply remove it, as the tutorial is based on it being here. not sure how much is missing to tag a stable version of routing-auto?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the tricky bit is .. does this even still work? even if it does today .. how long will it still work? if at all we need to set a fixed release here imho

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for locking on a specific commit or alphaX tag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's change it to a specific alpha tag.

It is indeed a bit tricky. To be honest, the whole tutorial is tricky. It is almost completely based on unstable features. On the other hand, it is one of the best parts of the docs for beginners currently. That's the reason it is in there.

We might want to check it and see what we get if we remove unstable features for the tutorial. Then we can keep the "old" tutorial in the dev branch and merge it when the features are stable.

"symfony-cmf/menu-bundle": "1.0",
"sonata-project/doctrine-phpcr-admin-bundle": "dev-master",
"symfony-cmf/tree-browser-bundle": "@dev",
"sonata-project/doctrine-phpcr-admin-bundle": "1.0.*",
"symfony-cmf/tree-browser-bundle": "1.0.*",
"doctrine/data-fixtures": "1.0.0",

"doctrine/phpcr-odm": "dev-master as 1.0.0",
"phpcr/phpcr-utils": "dev-master as 1.0.0",
"doctrine/phpcr-bundle": "dev-master as 1.0.0",
"symfony-cmf/routing-bundle": "dev-master as 1.1.0",
"symfony-cmf/routing": "dev-master as 1.2.0"
"doctrine/phpcr-odm": "1.0.*",
"phpcr/phpcr-utils": "1.0.*",
"doctrine/phpcr-bundle": "1.0.*"
"symfony-cmf/routing-bundle": "1.1.*",
"symfony-cmf/routing": "1.1.*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need 1.2.0 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will collide / overlap with #480

in that PR i go for the new versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, this PR is against master... then we just will have to solve a conflict when merging master into dev.

},
...
}

.. note::

This tutorial currently requires code only available in the lastest
unstable version of PHPCR-ODM, this is why you require the "dev-master as
1.0.0" constraints. When PHPCR-ODM 1.1 is released this will no longer be
necessary.

Note that each time you modify your ``composer.json`` file you are required to
run ``composer update``.

Expand Down
2 changes: 1 addition & 1 deletion cookbook/creating_a_cms/sonata-admin.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Ensure that you have the following package installed:
...
require: {
...
"sonata-project/doctrine-phpcr-admin-bundle": "dev-master",
"sonata-project/doctrine-phpcr-admin-bundle": "1.0.*",
},
...
}
Expand Down
2 changes: 1 addition & 1 deletion cookbook/creating_cms_using_cmf_and_sonata.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Add the following to your ``composer.json`` file:
"require": {
...
"sonata-project/doctrine-phpcr-admin-bundle": "1.0.*",
"sonata-project/core-bundle": "~2.2@dev"
"sonata-project/core-bundle": "~2.2"
}

And then run:
Expand Down
2 changes: 1 addition & 1 deletion cookbook/editions/cmf_sandbox.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ Next, you need to install the actual Doctrine DBAL bundle required by jackalope:

.. code-block:: bash

$ php composer.phar require jackalope/jackalope-doctrine-dbal:dev-master
$ php composer.phar require jackalope/jackalope-doctrine-dbal:1.0.*

And create and init your database:

Expand Down
2 changes: 1 addition & 1 deletion cookbook/installing_configuring_doctrine_phpcr_odm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ content repository.
"minimum-stability": "dev",
"require": {
...
"jackalope/jackalope-doctrine-dbal": "dev-master",
"jackalope/jackalope-doctrine-dbal": "1.0.*",
"doctrine/phpcr-bundle": "1.0.*",
"doctrine/phpcr-odm": "1.0.*"
}
Expand Down