Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 89d4b17
Choose a base ref
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d6d0cc3
Choose a head ref
  • 10 commits
  • 4 files changed
  • 7 contributors

Commits on Feb 14, 2021

  1. [Console] Fix PHP 8.1 null error for preg_match flag

    Since PHP 8.1, null is no longer accepted as $flags, default integer `0` value should be used instead.
    kylekatarnls authored Feb 14, 2021
    Configuration menu
    Copy the full SHA
    271b628 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. bug #40187 [Console] Fix PHP 8.1 null error for preg_match flag (kyle…

    …katarnls)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Console] Fix PHP 8.1 null error for preg_match flag
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Since PHP 8.1, `null` is no longer accepted as `$flags` in `preg_match`, default integer `0` value should be used instead.
    
    Commits
    -------
    
    52f02e529a [Console] Fix PHP 8.1 null error for preg_match flag
    xabbuh committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    cc8529a View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.4' into 5.2

    * 4.4:
      Fix PHP 8.1 null values
      [Console] Fix PHP 8.1 null error for preg_match flag
      Fix: Article
      Definition::removeMethodCall should remove all matching calls
      mark the LazyIterator class as internal
      fix extracting mixed type-hinted property types
      keep valid submitted choices when additional choices are submitted
    chalasr committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    65fcd28 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. [Console] fix QuestionHelper::getHiddenResponse() not working with sp…

    …ace in project directory name
    Yendric authored and chalasr committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    3650057 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Merge branch '4.4' into 5.2

    * 4.4:
      install compatible versions of mongodb/mongodb only
      fix resolving parent/self/static type annotations
      [Console] fix QuestionHelper::getHiddenResponse() not working with space in project directory name
      [WebLink] Escape double quotes in attributes values
    xabbuh committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    72cd4bb View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Configuration menu
    Copy the full SHA
    654d0c8 View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.4' into 5.2

    * 4.4:
      Switched to non-null defaults in exception constructors
      [Routing] fix conflict with param named class in attribute
      [Cache] fix setting items' metadata on commit()
    nicolas-grekas committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    21e8ac3 View commit details
    Browse the repository at this point in the history
  3. In calls to mb_ functions, silently transform arg into string

    In PHP8, a number of functions who were accepting null arguments will only accept
    string ones.
    
    In the polyfill, mb_* functions are declared with a trict type checking of "string".
    
    Therefore, we deprecate the use of non string arguments, so that it won't break when either using the polyfill,
    or future php8 versions.
    Yopai committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    bee5a5b View commit details
    Browse the repository at this point in the history
  4. minor #40272 [Console] Handle calls to mb_ functions with non string …

    …arguments (Yopai)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Console] Handle calls to mb_ functions with non string arguments
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #40200
    | License       | MIT
    | Doc PR        | no
    
    In PHP8.1, a number of functions who were accepting null arguments will only accept
    string ones.
    (see https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg)
    
    In the polyfill, mb_* functions are already declared with a strict type checking of "string".
    
    Therefore, it is necessary to get rid of the use of non string arguments when calling mb_* functions,
    so that it won't break when either using the polyfill,or future php8 versions.
    
    In every call where the argument may not be a string, this commit enforces the string type of the argument (with transtyping)
    
    --- For reviewers
    * I generally don't like transtyping, but found it was the more "secure" way (on a non-BC point of view) here.
    Specially in Console/Helper/Table.php, where $cell can be an object (there are 2 "$cell instanceof ... tests)
    However, where the argument can already be either null or string (and not anything else), there may a beter approach ?
    
    * It's the first time I send a PR on symfony, so don't hesitate pointing me to thinks I've forgotten to done.
    
    Commits
    -------
    
    ac45be2580 In calls to mb_ functions, silently transform arg into string
    nicolas-grekas committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c98349b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Merge branch '4.4' into 5.2

    * 4.4:
      Move github templates at the org level
      [Cache] Fix Redis TLS scheme `rediss` for Redis connection
      In calls to mb_ functions, silently transform arg into string
    nicolas-grekas committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    d6d0cc3 View commit details
    Browse the repository at this point in the history
Loading