Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e84aab1
Choose a base ref
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0585538
Choose a head ref
  • 8 commits
  • 3 files changed
  • 5 contributors

Commits on May 13, 2021

  1. [Console] Fix Windows code page support

    @orkan
    orkan committed May 13, 2021
    Configuration menu
    Copy the full SHA
    5809712 View commit details
    Browse the repository at this point in the history

  2. bug #41210 [Console] Fix Windows code page support (orkan) 

    This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Fix Windows code page support

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37385, Fix #35842, Fix #36324, Fix #37495, Fix #37278
| License       | MIT

Corrects mojibake problem on Windows where an OEM code page was applied to an input string and then messed with PHP.internal_encoding setting used by the script. This caused strings with different encodings to be displayed on the console output.

Commits
-------

41452785c6 [Console] Fix Windows code page support
    @nicolas-grekas
    nicolas-grekas committed May 13, 2021
    Configuration menu
    Copy the full SHA
    1b15ca1 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Invalid copy-paste fix

    @a-menshchikov
    a-menshchikov committed May 19, 2021
    Configuration menu
    Copy the full SHA
    c560f8d View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Fix PHP 8.1 deprecations

    @derrabus
    derrabus committed May 20, 2021
    Configuration menu
    Copy the full SHA
    71113af View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Merge branch '5.2' into 5.3 

    * 5.2:
  Wrapping exception js in Sfjs check and also loading base_js Sfjs if needed
  Fix PHP 8.1 deprecations
  Add missing deprecation entry
  [VarDumper] Don't pass null to parse_url()
    @derrabus
    derrabus committed May 21, 2021
    Configuration menu
    Copy the full SHA
    a549ee0 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Fix markdown

    @OskarStark
    OskarStark committed May 26, 2021
    Configuration menu
    Copy the full SHA
    a62acec View commit details
    Browse the repository at this point in the history

  2. Merge branch '4.4' into 5.2 

    * 4.4:
  Fix markdown
    @nicolas-grekas
    nicolas-grekas committed May 26, 2021
    Configuration menu
    Copy the full SHA
    9e18ae5 View commit details
    Browse the repository at this point in the history

  3. Merge branch '5.2' into 5.3 

    * 5.2:
  Fix CS in README files
  Fix markdown
  [HttpKernel] Fixes tests for PHP7.4+
  [Filesystem] fix readlink for Windows
    @nicolas-grekas
    nicolas-grekas committed May 26, 2021
    Configuration menu
    Copy the full SHA
    0585538 View commit details
    Browse the repository at this point in the history
Loading