-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
A locale in this context is a comination of a language, a script and … #13261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
friendly ping @ro0NL, I would love to get your review on this PR 🙃
What about using something similar to the Wikipedia definition of "locale":
|
@javiereguiluz I think the definition on Wikipedia is to general for what is meant here. A locale here is almost always a combination of a language code, a country code and a script code and not the combination of a language code, a country code and some parameters. But anyway I changed the commit to this version. |
@michaelKaefer thanks for updating your contribution. I wasn't sure about this either ... but looking at Symfony Intl tests (https://github.com/symfony/intl/blob/master/Tests/Locale/LocaleTest.php) it looks like we support locales with attributes like script, currency formatting, etc. |
@javiereguiluz Ok, thank you. But |
@michaelKaefer nice work! ... and thanks for your patience during the review process |
…a region