Skip to content

[WebLink] Adding missing "as" to style link header #19043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

weaverryan
Copy link
Member

Hi!

The "as" is needed for preload. Notice that it is already included in the next example, but missing here (and there is no magic where the $this->addLink() method adds the as).

Cheers!

@carsonbot carsonbot added this to the 6.4 milestone Oct 18, 2023
@carsonbot carsonbot changed the title Adding missing "as" to style link header [WebLink] Adding missing "as" to style link header Oct 19, 2023
@javiereguiluz
Copy link
Member

Thank you Ryan.

@javiereguiluz javiereguiluz merged commit 0349081 into 6.4 Oct 19, 2023
@javiereguiluz javiereguiluz deleted the web-link-add-as branch October 19, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants