[Form] added prototype_data option in CollectionType #6450

HeahDude · 2016-04-09T12:15:29Z

Q	A
Branch	2.8+
New doc	finishes #4367

xabbuh · 2016-04-11T08:50:16Z

reference/forms/types/collection.rst

+
+**type**: ``mixed`` **default**: ``null``
+
+Allows you to define a specific data for the prototype. Each new row added will


[...] define specific data [...]

xabbuh · 2016-04-11T08:51:12Z

We need a versionadded directive for this option.

xabbuh · 2016-04-11T08:52:34Z

reference/forms/types/collection.rst

+    use Symfony\Component\Form\Extension\Core\Type\TextType;
+
+    $builder->add('tags', CollectionType::class, array(
+        'class' => \AppBundle\Entity\Tag::class,


For the Symfony 2.8 docs we always use a string to be compatible with PHP 5.3 and 5.4.

HeahDude · 2016-04-11T09:05:05Z

@xabbuh Thanks for the review, comments addressed.

xabbuh · 2016-04-11T09:07:37Z

reference/forms/types/collection.rst

+.. code-block:: php
+
+    use Symfony\Component\Form\Extension\Core\Type\CollectionType;
+    use Symfony\Component\Form\Extension\Core\Type\TextType;


The use statements are useless now. :)

Right, I made another commit to do that change in all examples, so you can easily revert it in 3.0+ branches. Thanks!

xabbuh · 2016-04-11T09:28:24Z

👍

weaverryan · 2016-04-12T01:07:34Z

reference/forms/types/collection.rst

-    // ...
-
-    $builder->add('emails', CollectionType::class, array(
+    $builder->add('emails', 'Symfony\Component\Form\Extension\Core\Type\CollectionType', array(


Why the change away from the CollectionType::class? That option (with ::class) seems a little easier because we can use IDE auto-completion. Or have we been changing this elsewhere?

@weaverryan, the discussion with @xabbuh is on the outdated diff: #6450 (comment)
Because 2.8 supports PHP < 5.5, I made a different commit for those changes so it can be reverted in 3.0.
Thanks :)

@HeahDude It looks like I was mistaken here and we at some point agreed on using the class constant even in the 2.8 docs (see http://symfony.com/doc/2.8/book/forms.html, for example). Sorry for the confusion.

@xabbuh No worry, I just removed the last commit :)

HeahDude · 2016-04-14T12:54:13Z

reference/forms/types/collection.rst

+    // ...
+
+    $builder->add('tags', CollectionType::class, array(
+        'class' => 'AppBundle\Entity\Tag',


@xabbuh, I intentionally didn't change this one since it's almost the same:
'AppBundle\Entity\Tag' VS \AppBundle\Entity\Tag::class unless we add a use statement:

use AppBundle\Entity\Tag; // ... 'class' => Tag::class

What do you like ?

Actually, I was a bit confused and I am even more confused now. Where from did you take the class option?

My bad, confusion with EntityType! ~~Should be entry_type~~ data_class in entry_options, I'll just remove it :)

Oh okay, but entry_type is already set to refer to the TextType, isn't it?

Yes I answered too quickly and edited it.

…ta` option

HeahDude · 2016-04-14T16:58:11Z

Ok should be good now.

xabbuh · 2016-04-14T17:00:26Z

Cool 👍

…gilden, HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [Form] added prototype_data option in CollectionType | Q | A | |----|----| | Branch | 2.8+ | | New doc | finishes #4367 | Commits ------- 95bda57 [Form] defined default and added example CollectionType `prototype_data` option e18dc1f [Form] Document CollectionType's `prototype_data`

wouterj · 2016-04-18T20:43:53Z

Thanks for your work on this @HeahDude and @kgilden! It's finally merged now.

Fyi, I've added a reference to the entry_options setting in 326ae53.

HeahDude · 2016-04-18T21:31:15Z

Nice addition, thank you @wouterj! Also thanks to @kgilden @xabbuh

…Type (kgilden, HeahDude)

HeahDude force-pushed the fix/form_type-prototype_data_option branch 2 times, most recently from befaeb4 to 6f15771 Compare April 9, 2016 13:57

xabbuh mentioned this pull request Apr 11, 2016

[Form] Document CollectionType's prototype_data option #4367

Closed

xabbuh reviewed Apr 11, 2016
View reviewed changes

xabbuh added the Status: Needs Work label Apr 11, 2016

HeahDude force-pushed the fix/form_type-prototype_data_option branch from 6f15771 to 1b5e46e Compare April 11, 2016 09:03

xabbuh reviewed Apr 11, 2016
View reviewed changes

HeahDude force-pushed the fix/form_type-prototype_data_option branch from 1b5e46e to 2034e96 Compare April 11, 2016 09:26

xabbuh added Status: Reviewed and removed Status: Needs Work labels Apr 11, 2016

weaverryan reviewed Apr 12, 2016
View reviewed changes

HeahDude force-pushed the fix/form_type-prototype_data_option branch from 2034e96 to 3c08e10 Compare April 13, 2016 06:55

HeahDude reviewed Apr 14, 2016
View reviewed changes

kgilden and others added 2 commits April 14, 2016 18:57

[Form] Document CollectionType's prototype_data

e18dc1f

[Form] defined default and added example CollectionType `prototype_da…

95bda57

…ta` option

HeahDude force-pushed the fix/form_type-prototype_data_option branch from 3c08e10 to 95bda57 Compare April 14, 2016 16:57

wouterj merged commit 95bda57 into symfony:2.8 Apr 18, 2016

wouterj added a commit that referenced this pull request Apr 18, 2016

[#6450] Use a reference for the field option

326ae53

HeahDude deleted the fix/form_type-prototype_data_option branch April 18, 2016 21:31

wouterj added a commit to wouterj/symfony-docs that referenced this pull request Apr 20, 2016

feature symfony#6450 [Form] added prototype_data option in Collection…

323ebcc

…Type (kgilden, HeahDude)

wouterj added a commit that referenced this pull request Apr 20, 2016

[#6450] Remove versionadded in 3.0

3b1f19e

wouterj added a commit that referenced this pull request Apr 20, 2016

[#6450] Use a reference for the field option

5439c7a


		type: ``mixed`` default: ``null``

		Allows you to define a specific data for the prototype. Each new row added will

Uh oh!

[Form] added prototype_data option in CollectionType #6450

[Form] added prototype_data option in CollectionType #6450

Uh oh!

Conversation

HeahDude commented Apr 9, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Apr 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeahDude commented Apr 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xabbuh commented Apr 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeahDude commented Apr 14, 2016

Uh oh!

xabbuh commented Apr 14, 2016

Uh oh!

wouterj commented Apr 18, 2016

Uh oh!

HeahDude commented Apr 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants