Add Feature, Capitalize the first letter of Category name #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shabab sha5iet |
jreflores
reviewed
Aug 27, 2023
| changeHandler(editingCategoryId, event.target.value) | ||
| changeHandler( | ||
| editingCategoryId, | ||
| event.target.value.charAt(0).toUpperCase() + event.target.value.slice(1) |
There was a problem hiding this comment.
You can make this simple by using lodash's capitalize(). Also encourage to write unit or e2e test for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please read the Contribution Guidelines before opening a pull request. Include a summary of the change and which issue is fixed.
Closes # <-- link the issue number here
Browser checklist
This PR has been tested in the following browsers:
Testing checklist