refactor: update note handling and improve title display #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded package-lock.json to version 3 and replaced node-sass with sass. - Refactored note title retrieval to use getDisplayTitle instead of getNoteTitle for better title management. - Added rename functionality in the context menu for notes, allowing users to edit note titles directly. - Enhanced note editing state management in the Redux slice to support temporary title changes. - Updated various components to reflect changes in note title handling and ensure consistent display across the application.
…tracking - Updated the regex pattern used in the setEditorOverlay function to be bounded and non-nested, enhancing performance and preventing potential issues with super-linear backtracking.
- Replaced anchor tags with buttons in NoteLink for better accessibility. - Added keyboard event handling for Tab and Category components to support Enter and Space key interactions. - Updated event handling in NoteList and CategoryList to manage keyboard events for context menus and note options. - Improved context menu positioning for keyboard events to enhance user experience.
uplabhijit
approved these changes
Aug 27, 2025
uplabhijit
approved these changes
Aug 27, 2025
Author
|
@uplabhijit May you please approve with right access |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please read the Contribution Guidelines before opening a pull request. Include a summary of the change and which issue is fixed.
Closes #620
Browser checklist
This PR has been tested in the following browsers:
Testing checklist
Screenshots