This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Don't upload small tensors as uniforms to packed op programs #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trivial: modify the check to prevent upload to uniform when texData.isPacked == true and program.usesPackedTextures == true. BUG
|
@annxingyuan PTAL. |
annxingyuan
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
LGTM - thanks a lot @astojilj for catching this! Feel free to merge.
Thanks. I don't have write access required to merge it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial: modify the check to prevent upload to uniform when
texData.isPacked == true and program.usesPackedTextures == true.
BUG
Description
I got this reproduced from batchnorm tests with packed binary PR on and this modification of batchnormalization4D tests.
This test would run existing batchnormTests with WEBGL_PACK flag on.
although texData.isPacked == true, and program.usesPackedTextures == true. the logic would still upload the tensor to uniform.
For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md
This change is