Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Simplify tf.ENV.registerBackend (remove setTensorTracker param) #1517

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Jan 28, 2019

There is no need for custom backends to provide their own tensor trackers since the tracker is the engine (a global).

Tested that double tfjs import works:

<script src="tf-core.min.js"></script>
<script src="tf-core.min.js"></script>
<script>
	tf.square(3).print();
</script>

This change is Reviewable

@dsmilkov dsmilkov requested review from pyu10055 and nsthorat January 28, 2019 20:15
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat and @pyu10055)

Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @pyu10055)

@dsmilkov dsmilkov merged commit ef29cc1 into master Jan 29, 2019
@dsmilkov dsmilkov deleted the fix-tracker branch January 29, 2019 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants