Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Update master version to 1.0.0-alpha1. #1527

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Update master version to 1.0.0-alpha1. #1527

merged 1 commit into from
Feb 3, 2019

Conversation

nsthorat
Copy link
Contributor

@nsthorat nsthorat commented Feb 3, 2019

Also update the publish-npm script to use --tag next so we don't accidentally publish 1.0 under the @latest tag.


This change is Reviewable

@nsthorat nsthorat requested a review from dsmilkov February 3, 2019 03:09
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov)

@nsthorat
Copy link
Contributor Author

nsthorat commented Feb 3, 2019

tfjs-converter build fails, but I need to do the alpha release of core before I can cherry pick the fix in tfjs-converter over (from 0.8.x to the master branch).

@nsthorat
Copy link
Contributor Author

nsthorat commented Feb 3, 2019

And to be clear: we don't have to do the first alpha release yet. Let's check in some of the breaking changes to core first, then I'll update the other packages to depend on alpha.

@nsthorat nsthorat merged commit d522844 into master Feb 3, 2019
@nsthorat nsthorat deleted the alpha branch February 3, 2019 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants