Skip to content
This repository was archived by the owner on Aug 15, 2019. It is now read-only.

Preserve docs in npm package #1533

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Preserve docs in npm package #1533

merged 2 commits into from
Feb 5, 2019

Conversation

tafsiri
Copy link
Contributor

@tafsiri tafsiri commented Feb 4, 2019

This fixes tensorflow/tfjs#1180 and allows users to see docs in code editors like vscode.

Note that the docs are still removed from the minified bundle.


This change is Reviewable

This fixes tensorflow/tfjs#1180 and allows users to see docs in code editors like vscode.

Note that the docs are still removed from the minified bundle.
@tafsiri tafsiri requested review from nsthorat and dsmilkov February 4, 2019 19:25
Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @dsmilkov and @nsthorat)

@tafsiri tafsiri merged commit 8f1f8b1 into master Feb 5, 2019
@tafsiri tafsiri deleted the docs-in-package branch February 5, 2019 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(docs): add doc comments
2 participants